| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20191021042706.GA2654@vkoul-mobl>
Date: Mon, 21 Oct 2019 09:57:06 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: robh@...nel.org, broonie@...nel.org, bgoswami@...eaurora.org,
pierre-louis.bossart@...ux.intel.com, devicetree@...r.kernel.org,
lgirdwood@...il.com, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, spapothi@...eaurora.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom
controller
On 11-10-19, 16:44, Srinivas Kandagatla wrote:
> This patch adds bindings for Qualcomm soundwire controller.
>
> Qualcomm SoundWire Master controller is present in most Qualcomm SoCs
> either integrated as part of WCD audio codecs via slimbus or
> as part of SOC I/O.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> .../bindings/soundwire/qcom,sdw.txt | 167 ++++++++++++++++++
> 1 file changed, 167 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>
> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> new file mode 100644
> index 000000000000..436547f3b155
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> @@ -0,0 +1,167 @@
> +Qualcomm SoundWire Controller Bindings
> +
> +
> +This binding describes the Qualcomm SoundWire Controller along with its
> +board specific bus parameters.
> +
> +- compatible:
> + Usage: required
> + Value type: <stringlist>
> + Definition: must be "qcom,soundwire-v<MAJOR>.<MINOR>.<STEP>",
> + Example:
> + "qcom,soundwire-v1.3.0"
> + "qcom,soundwire-v1.5.0"
> + "qcom,soundwire-v1.6.0"
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: the base address and size of SoundWire controller
> + address space.
> +
> +- interrupts:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should specify the SoundWire Controller IRQ
> +
> +- clock-names:
> + Usage: required
> + Value type: <stringlist>
> + Definition: should be "iface" for SoundWire Controller interface clock
> +
> +- clocks:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should specify the SoundWire Controller interface clock
> +
> +- #sound-dai-cells:
> + Usage: required
> + Value type: <u32>
> + Definition: must be 1 for digital audio interfaces on the controller.
> +
> +- qcom,dout-ports:
> + Usage: required
> + Value type: <u32>
> + Definition: must be count of data out ports
> +
> +- qcom,din-ports:
> + Usage: required
> + Value type: <u32>
> + Definition: must be count of data in ports
> +
> +- qcom,ports-offset1:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should specify payload transport window offset1 of each
> + data port. Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-offset2:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should specify payload transport window offset2 of each
> + data port. Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
Do we need to define these two in DT? Would this not be allocated in
Software and programmed?
> +
> +- qcom,ports-sinterval-low:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should be sample interval low of each data port.
> + Out ports followed by In ports. Used for Sample Interval
> + calculation.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-word-length:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be size of payload channel sample.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-block-pack-mode:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be 0 or 1 to indicate the block packing mode.
> + 0 to indicate Blocks are per Channel
> + 1 to indicate Blocks are per Port.
> + Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-block-group-count:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be in range 1 to 4 to indicate how many sample
> + intervals are combined into a payload.
> + Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-lane-control:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be in range 0 to 7 to identify which data lane
> + the data port uses.
> + Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-hstart:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be number identifying lowerst numbered coloum in
> + SoundWire Frame, i.e. left edge of the Transport sub-frame
> + for each port. Values between 0 and 15 are valid.
> + Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> +
> +- qcom,ports-hstop:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: should be number identifying highest numbered coloum in
> + SoundWire Frame, i.e. the right edge of the Transport
> + sub-frame for each port. Values between 0 and 15 are valid.
> + Out ports followed by In ports.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
Ditto with these two as well
--
~Vinod
Powered by blists - more mailing lists