linux-kernel - Re: [PATCH] usb: dwc3: select CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 16:19:36 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Arnd Bergmann <arnd@...db.de>, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Roger Quadros <rogerq@...com>,
        Lee Jones <lee.jones@...aro.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO

On 21/10/2019 16:18, Arnd Bergmann wrote:
> After many randconfig builds, one configuration caused a link
> error with dwc3-meson-g12a lacking the regmap-mmio code:
> 
> drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
> dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'
> 
> Add the select statement that we have for all other users
> of that dependency.
> 
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/usb/dwc3/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 89abc6078703..556a876c7896 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -102,6 +102,7 @@ config USB_DWC3_MESON_G12A
>         depends on ARCH_MESON || COMPILE_TEST
>         default USB_DWC3
>         select USB_ROLE_SWITCH
> +	select REGMAP_MMIO
>         help
>           Support USB2/3 functionality in Amlogic G12A platforms.
>  	 Say 'Y' or 'M' if you have one such device.
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>