linux-kernel - RE: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f07f4aad98e44358b92e1e340df131f@AcuMS.aculab.com>
Date:   Mon, 21 Oct 2019 14:46:20 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Yunsheng Lin' <linyunsheng@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "dsahern@...il.com" <dsahern@...il.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "allison@...utok.net" <allison@...utok.net>,
        "mmanning@...tta.att-mail.com" <mmanning@...tta.att-mail.com>,
        "petrm@...lanox.com" <petrm@...lanox.com>,
        "dcaratti@...hat.com" <dcaratti@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when
 setting initial MTU

From: Yunsheng Lin
> Sent: 21 October 2019 13:26
> Currently the MTU of vlan netdevice is set to the same MTU
> of the lower device, which requires the underlying device
> to handle it as the comment has indicated:
> 
> 	/* need 4 bytes for extra VLAN header info,
> 	 * hope the underlying device can handle it.
> 	 */
> 	new_dev->mtu = real_dev->mtu;
> 
> Currently most of the physical netdevs seems to handle above
> by reversing 2 * VLAN_HLEN for L2 packet len.

s/reverse/reserve/g

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)