linux-kernel - Re: [PATCH 3/3] firmware/dmi: Report DMI Embedded Firmware release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021165513.24e24d53@endymion>
Date:   Mon, 21 Oct 2019 16:55:13 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     "Erwan Velu" <erwanaliasr1@...il.com>
Cc:     "Robert P. J. Day" <rpjday@...shcourse.ca>,
        "Erwan Velu" <e.velu@...teo.com>,
        "Changbin Du" <changbin.du@...el.com>,
        "Boris Brezillon" <bbrezillon@...nel.org>,
        "Sumit Garg" <sumit.garg@...aro.org>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Michal Marek" <michal.lkml@...kovi.net>,
        "Mattias Jacobsson" <2pi@....nu>,
        "Masahiro Yamada" <yamada.masahiro@...ionext.com>,
        <linux-kbuild@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] firmware/dmi: Report DMI Embedded Firmware release

On Wed, 18 Sep 2019 11:43:21 +0200, Erwan Velu wrote:
> Servers that have a BMC encodes the release version of their firmware
> in the "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0.
> 
> This information is useful to know which release of the BMC is actually running.
> It could be used for some quirks, debugging sessions or inventory tasks.
> 
> This patch extract these 2 fields in DMI_EMBEDDED_FW_MAJOR_RELEASE & DMI_EMBEDDED_FW_MINOR_RELEASE
> 
> A typical output for a Dell system running the 3.75 bios is :
> 
>     [root@...00 ~]# cat /sys/devices/virtual/dmi/id/fw_release_major
>     3
>     [root@...00 ~]# cat /sys/devices/virtual/dmi/id/fw_release_minor
>     75
>     [root@...00 ~]#

Same comment here as for previous patch, obviously.

Additionally, please run scripts/checkpatch.pl on your patch before you
resubmit, and address all the problems reported.

Thanks,
-- 
Jean Delvare
SUSE L3 Support