linux-kernel - Re: [PATCH 2/5] mfd: rn5t618: add irq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 17:06:20 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     lee.jones@...aro.org, a.zummo@...ertech.it,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        phh@....me, b.galvani@...il.com, stefan@...er.ch,
        letux-kernel@...nphoenux.org
Subject: Re: [PATCH 2/5] mfd: rn5t618: add irq support

On Mon, 21 Oct 2019 11:07:10 +0200
Alexandre Belloni <alexandre.belloni@...tlin.com> wrote:

> Hi,
> 
> On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote:
> > +#if 0
> > +/*
> > + * REVISIT when implementing charger:
> > + * according to some other implementation it needs special treatment,
> > + * inverted but experiments seem not to confirm that.
> > + */
> > +	[RN5T618_IRQ_CHG] = {
> > +		.reg_offset = 0,
> > +		.mask = (1 << 6),
> > +	}
> > +#endif  
> 
> Please avoid submitting dead code.
> 
ok, I can do some more testing here and add that thing properly.

Regards,
Andreas

Content of type "application/pgp-signature" skipped