linux-kernel - Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 17:20:55 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Stefan Agner <stefan@...er.ch>, lee.jones@...aro.org,
        a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org, phh@....me, b.galvani@...il.com,
        letux-kernel@...nphoenux.org
Subject: Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

On Mon, 21 Oct 2019 15:50:28 +0200
Alexandre Belloni <alexandre.belloni@...tlin.com> wrote:

> On 21/10/2019 15:19:09+0200, Stefan Agner wrote:
> > On 2019-10-21 07:41, Andreas Kemnade wrote:  
> > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619,
> > > which is implemented as a variant of rn5t618
> > > 
> > > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > > ---
> > >  drivers/rtc/Kconfig       |  10 +
> > >  drivers/rtc/Makefile      |   1 +
> > >  drivers/rtc/rtc-rc5t619.c | 476 ++++++++++++++++++++++++++++++++++++++++++++++  
> > 
> > Parts of this driver look very similar to drivers/rtc/rtc-rc5t583.c. Can
> > it maybe shared?
> >   
> 
> If this could be done it would be better. I can't find any public
> datasheet though...
> 
at least they have different alarm configurations, The rc5t619 can specify
alarm in seconds, the rc5t583 not but has other alarm configurations which
are not present in the rn5t619 (judging by the lack of unused registers where
thoes information could be filled in). 

Register addresses do not match.
Some details seem to be the same like century flag.
Interestingly the rc5t583 driver does not care about 12h/24h mode.
So there is a bug there. 

Regards,
Andreas

Content of type "application/pgp-signature" skipped