linux-kernel - RE: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Oct 2019 12:23:11 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Anup Patel <Anup.Patel@....com>
cc:     Palmer Dabbelt <palmer@...ive.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        Greg KH <gregkh@...uxfoundation.org>,
        "rkir@...gle.com" <rkir@...gle.com>,
        Atish Patra <Atish.Patra@....com>,
        Alistair Francis <Alistair.Francis@....com>,
        Christoph Hellwig <hch@...radead.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver

On Mon, 14 Oct 2019, Anup Patel wrote:

> > -----Original Message-----
> > From: Palmer Dabbelt <palmer@...ive.com>
> > Sent: Saturday, October 12, 2019 11:09 PM
> > To: Anup Patel <Anup.Patel@....com>
> > Cc: Paul Walmsley <paul.walmsley@...ive.com>; aou@...s.berkeley.edu;
> > Greg KH <gregkh@...uxfoundation.org>; rkir@...gle.com; Atish Patra
> > <Atish.Patra@....com>; Alistair Francis <Alistair.Francis@....com>;
> > Christoph Hellwig <hch@...radead.org>; anup@...infault.org; linux-
> > riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Anup Patel
> > <Anup.Patel@....com>
> > Subject: Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver
> > 
> > On Tue, 24 Sep 2019 23:38:08 PDT (-0700), Anup Patel wrote:
> > > We have Goldfish RTC device available on QEMU RISC-V virt machine
> > > hence enable required driver in RV32 and RV64 defconfigs.

My understanding is that the Goldfish support is still under 
discussion on the QEMU side and isn't merged yet - is that accurate?

https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04904.html

> > 
> > Reviewed-by: Palmer Dabbelt <palmer@...ive.com>
> > 
> > IIRC there was supposed to be a follow-up to your QEMU patch set to rebase
> > it on top of a refactoring of their RTC code, but I don't see it in my inbox.  LMK
> > if I missed it, as QEMU's soft freeze is in a few weeks and I'd like to make
> > sure I get everything in.
> 
> I was hoping for QEMU RTC refactoring to be merged soon but it has not
> happened so far. I will wait couple of more days then send v3 of QEMU
> patches.

The patch looks fine to me, but let's wait until the underlying support 
actually appears on the QEMU "hardware".  Could you resend once that's 
happened?

thanks,

- Paul