linux-kernel - Re: [PATCH v2 11/13] drivers: irqchip: qcom-pdc: Add irqchip for sc7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecca1dde-6729-2ad0-4a30-b5a6de335198@codeaurora.org>
Date:   Tue, 22 Oct 2019 10:55:51 +0530
From:   Maulik Shah <mkshah@...eaurora.org>
To:     Marc Zyngier <maz@...nel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>
Cc:     agross@...nel.org, robh+dt@...nel.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH v2 11/13] drivers: irqchip: qcom-pdc: Add irqchip for
 sc7180


On 10/21/2019 1:40 PM, Marc Zyngier wrote:
> On 2019-10-21 07:55, Rajendra Nayak wrote:
>> From: Maulik Shah <mkshah@...eaurora.org>
>>
>> Add sc7180 pdc irqchip
>>
>> Signed-off-by: Maulik Shah <mkshah@...eaurora.org>
>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>> Cc: Lina Iyer <ilina@...eaurora.org>
>> Cc: Marc Zyngier <maz@...nel.org>
>> ---
>> v2: No change
>>
>>  drivers/irqchip/qcom-pdc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index faa7d61b9d6c..954fb599fa9c 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -310,3 +310,4 @@ static int qcom_pdc_init(struct device_node
>> *node, struct device_node *parent)
>>  }
>>
>>  IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> +IRQCHIP_DECLARE(pdc_sc7180, "qcom,sc7180-pdc", qcom_pdc_init);
>
> What I gather from these 3 irq-related patches is that as far as
> the PDC is concerned, SDM845/850 and SC7180 are strictly identical.
>
> Why the churn?
>
>         M.

Hi Marc,

Different compatible were used to distinguish since interrupt mapping 
(PDC to GIC) was earlier kept in driver.

Now since mapping is kept in DTSI, we can continue to use 
qcom,sdm845-pdc for sc7180.

i will submit another patch to make it more generic for all SoCs like 
"qcom,pdc".

Thanks,

Maulik

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation