[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <aaf0f585-3a06-8af1-e2f1-ab301e560d49@huawei.com>
Date: Tue, 22 Oct 2019 16:11:18 +0800
From: Yunfeng Ye <yeyunfeng@...wei.com>
To: Herbert Xu <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
<catalin.marinas@....com>, <will@...nel.org>,
<ard.biesheuvel@...aro.org>, <linux-crypto@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <hushiyuan@...wei.com>,
"linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: [PATCH v3] crypto: arm64/aes-neonbs - add return value of
skcipher_walk_done() in __xts_crypt()
A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"
Fix this by adding return value of skcipher_walk_done().
Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
---
v2 -> v3:
- add "Acked-by:"
v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()
arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;
kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}
if (err || likely(!tail))
--
2.7.4.3
Powered by blists - more mailing lists