linux-kernel - Re: [PATCH v2 0/2] mm: Memory offlining + page isolation cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f56744d-2c22-6c12-8fe8-4a71e791c467@redhat.com>
Date:   Tue, 22 Oct 2019 10:15:07 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Dan Williams <dan.j.williams@...el.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Oscar Salvador <osalvador@...e.de>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Pavel Tatashin <pavel.tatashin@...rosoft.com>,
        Pingfan Liu <kernelfans@...il.com>, Qian Cai <cai@....pw>,
        Vlastimil Babka <vbabka@...e.cz>,
        Wei Yang <richard.weiyang@...il.com>
Subject: Re: [PATCH v2 0/2] mm: Memory offlining + page isolation cleanups

On 22.10.19 10:08, Michal Hocko wrote:
> On Tue 22-10-19 08:52:28, David Hildenbrand wrote:
>> On 21.10.19 19:23, David Hildenbrand wrote:
>>> Two cleanups that popped up while working on (and discussing) virtio-mem:
>>>    https://lkml.org/lkml/2019/9/19/463
>>>
>>> Tested with DIMMs on x86.
>>>
>>> As discussed with michal in v1, I'll soon look into removing the use
>>> of PG_reserved during memory onlining completely - most probably
>>> disallowing to offline memory blocks with holes, cleaning up the
>>> onlining+offlining code.
>>
>> BTW, I remember that ZONE_DEVICE pages are still required to be set
>> PG_reserved. That has to be sorted out first.
> 
> Do they?

Yes, especially KVM code :/

> 
>> I remember that somebody was
>> working on it a while ago but didn't hear about that again. Will look into
>> that as well - should be as easy as adding a zone check (if there isn't a
>> pfn_to_online_page() check already). But of course, there might be special
>> cases ....
> 
> I remember Alexander didn't want to change the PageReserved handling
> because he was worried about unforeseeable side effects. I have a vague
> recollection he (or maybe Dan) has promissed some follow up clean ups
> which didn't seem to materialize.

I'm looking into it right now, especially the KVM part.

-- 

Thanks,

David / dhildenb