linux-kernel - RE: [PATCH] cpufreq: imx-cpufreq-dt: Correct i.MX8MN's default speed grade value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB391687A3723E810119A58866F5680@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 22 Oct 2019 08:36:52 +0000
From:   Anson Huang <anson.huang@....com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
CC:     "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] cpufreq: imx-cpufreq-dt: Correct i.MX8MN's default speed
 grade value

Hi, Viresh

> On 22-10-19, 12:39, Anson Huang wrote:
> > i.MX8MN has different speed grade definition compared to
> > i.MX8MQ/i.MX8MM, when fuses are NOT written, the default speed_grade
> > should be set to minimum available OPP defined in DT which is 1.2GHz,
> > the corresponding speed_grade value should be 0xb.
> >
> > Fixes: 5b8010ba70d5 ("cpufreq: imx-cpufreq-dt: Add i.MX8MN support")
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> >  drivers/cpufreq/imx-cpufreq-dt.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/cpufreq/imx-cpufreq-dt.c
> > b/drivers/cpufreq/imx-cpufreq-dt.c
> > index 35db14c..26531f0 100644
> > --- a/drivers/cpufreq/imx-cpufreq-dt.c
> > +++ b/drivers/cpufreq/imx-cpufreq-dt.c
> > @@ -44,19 +44,19 @@ static int imx_cpufreq_dt_probe(struct
> platform_device *pdev)
> >  	mkt_segment = (cell_value & OCOTP_CFG3_MKT_SEGMENT_MASK) >>
> > OCOTP_CFG3_MKT_SEGMENT_SHIFT;
> >
> >  	/*
> > -	 * Early samples without fuses written report "0 0" which means
> > -	 * consumer segment and minimum speed grading.
> > -	 *
> > -	 * According to datasheet minimum speed grading is not supported
> for
> > -	 * consumer parts so clamp to 1 to avoid warning for "no OPPs"
> > +	 * Early samples without fuses written report "0 0" which may NOT
> > +	 * match any OPP defined in DT. So clamp to minimum OPP defined
> in
> > +	 * DT to avoid warning for "no OPPs".
> >  	 *
> >  	 * Applies to i.MX8M series SoCs.
> >  	 */
> > -	if (mkt_segment == 0 && speed_grade == 0 && (
> > -			of_machine_is_compatible("fsl,imx8mm") ||
> > -			of_machine_is_compatible("fsl,imx8mn") ||
> > -			of_machine_is_compatible("fsl,imx8mq")))
> > -		speed_grade = 1;
> > +	if (mkt_segment == 0 && speed_grade == 0) {
> > +		if (of_machine_is_compatible("fsl,imx8mm") ||
> > +			of_machine_is_compatible("fsl,imx8mq"))
> 
> of_machine_is_compatible should come right below the above
> of_machine_is_compatible here, instead of a leading tab.

Ah, yes, fixed in V2.

Thanks,
Anson