linux-kernel - Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89b6bac1-11d5-d7ee-cee4-fb907638b9aa@codethink.co.uk>
Date:   Tue, 22 Oct 2019 09:42:11 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-kernel@...ts.codethink.co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in
 <linux/arch_topology.h>

On 21/10/2019 17:52, Sudeep Holla wrote:
> On Mon, Oct 21, 2019 at 05:25:30PM +0100, Ben Dooks (Codethink) wrote:
>> The parse_acpi_topology() is not declared anywhere which
>> causes the following sparse warning:
>>
>> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
>>
>> RFC: is this the best place to put it?
>>
>> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>
>> ---
>> Cc: Sudeep Holla <sudeep.holla@....com>
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   include/linux/arch_topology.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
>> index 42f2b5126094..7ae32900d9a2 100644
>> --- a/include/linux/arch_topology.h
>> +++ b/include/linux/arch_topology.h
>> @@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
>>   void reset_cpu_topology(void);
>>   #endif
>>   
>> +extern int parse_acpi_topology(void);
>> +
> 
> Can we drop extern like other declarations here ?
> Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?
> 
> Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.

Ok, thank you for the input.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html