linux-kernel - Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

Open Source and information security mailing list archives

Message-ID: <20191022084423.GB1531961@ulmo>
Date:   Tue, 22 Oct 2019 10:44:23 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Thierry Reding <treding@...dia.com>,
        David Airlie <airlied@...ux.ie>, Sean Paul <sean@...rly.run>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote:
> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@...il.com> wrote:
> > Fix typo where bits got compared (x < y) instead of shifted (x << y).
> 
> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers")
> Cc: Thierry Reding <treding@...dia.com>

I'm not sure we really need the Fixes: tag here. These defines aren't
used anywhere, so technically there's no bug.

Thierry

> 
> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
> > ---
> >  include/drm/drm_scdc_helper.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h
> > index f92eb2094d6b..6a483533aae4 100644
> > --- a/include/drm/drm_scdc_helper.h
> > +++ b/include/drm/drm_scdc_helper.h
> > @@ -50,9 +50,9 @@
> >  #define  SCDC_READ_REQUEST_ENABLE (1 << 0)
> >  
> >  #define SCDC_STATUS_FLAGS_0 0x40
> > -#define  SCDC_CH2_LOCK (1 < 3)
> > -#define  SCDC_CH1_LOCK (1 < 2)
> > -#define  SCDC_CH0_LOCK (1 < 1)
> > +#define  SCDC_CH2_LOCK (1 << 3)
> > +#define  SCDC_CH1_LOCK (1 << 2)
> > +#define  SCDC_CH0_LOCK (1 << 1)
> >  #define  SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK)
> >  #define  SCDC_CLOCK_DETECT (1 << 0)
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives