linux-kernel - Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1C=skow522Ge7w=ya2hK8TPS8ncusdyX-Ne4GBWB1H4A@mail.gmail.com>
Date:   Tue, 22 Oct 2019 12:26:09 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Jiri Kosina <jkosina@...e.cz>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>
Subject: Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

On Tue, Oct 22, 2019 at 6:34 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote:
> > Each of these drivers has a copy of the same trivial helper function to
> > convert the pointer argument and then call the native ioctl handler.
> >
> > We now have a generic implementation of that, so use it.
>
> I'd rather flipped your #7 (ceph_compat_ioctl() introduction) past
> that one...

The idea was to be able to backport the ceph patch as a bugfix
to stable kernels without having to change it or backport
compat_ptr_ioctl() as well.

If you still prefer it that way, I'd move to a simpler version of this
patch and drop the Cc:stable.

      Arnd