linux-kernel - Re: [PATCH] reset: zynqmp: Make reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b42b11c-d4c4-e7fc-1dc3-c6ac07ab8b1d@xilinx.com>
Date:   Tue, 22 Oct 2019 14:12:59 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org
Cc:     Michal Simek <michal.simek@...inx.com>, kernel@...gutronix.de
Subject: Re: [PATCH] reset: zynqmp: Make reset_control_ops const

On 22. 10. 19 13:55, Philipp Zabel wrote:
> The zynqmp_reset_ops structure is never modified. Make it const.
> 
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/reset/reset-zynqmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index 99e75d92dada..0144075b11a6 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -64,7 +64,7 @@ static int zynqmp_reset_reset(struct reset_controller_dev *rcdev,
>  					    PM_RESET_ACTION_PULSE);
>  }
>  
> -static struct reset_control_ops zynqmp_reset_ops = {
> +static const struct reset_control_ops zynqmp_reset_ops = {
>  	.reset = zynqmp_reset_reset,
>  	.assert = zynqmp_reset_assert,
>  	.deassert = zynqmp_reset_deassert,
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal