linux-kernel - Re: [PATCH 1/8] ftrace: add ftrace_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022153335.GC52920@lakrids.cambridge.arm.com>
Date:   Tue, 22 Oct 2019 16:33:35 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     jthierry@...hat.com, will@...nel.org, ard.biesheuvel@...aro.org,
        peterz@...radead.org, catalin.marinas@....com, deller@....de,
        jpoimboe@...hat.com, linux-kernel@...r.kernel.org,
        takahiro.akashi@...aro.org, mingo@...hat.com, james.morse@....com,
        jeyu@...nel.org, amit.kachhap@....com, svens@...ckframe.org,
        duwe@...e.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote:
> On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote:
> > On Tue, 22 Oct 2019 12:28:11 +0100
> > Mark Rutland <mark.rutland@....com> wrote:
> > > | /**
> > > |  * ftrace_init_nop - initialize a nop call site
> > > |  * @mod: module structure if called by module load initialization
> > > |  * @rec: the mcount call site record
> > 
> > Perhaps say "mcount/fentry"
> 
> This is the exact wording that ftrace_make_nop and ftrace_modify_call
> have. For consistency, I think those should all match.

Now that I read this again, I see what you meant.

If it's ok, I'll change those to:

| @rec: the call site record (e.g. mcount/fentry)

Thanks,
Mark.