linux-kernel - RE: [PATCH] crypto: inside-secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR20MB29732A5C1B14AE24DD7531A3CA680@MN2PR20MB2973.namprd20.prod.outlook.com>
Date:   Tue, 22 Oct 2019 15:42:53 +0000
From:   Pascal Van Leeuwen <pvanleeuwen@...imatrix.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
CC:     Antoine Tenart <antoine.tenart@...tlin.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Pascal van Leeuwen <pascalvanl@...il.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3

> -----Original Message-----
> From: Arnd Bergmann <arnd@...db.de>
> Sent: Tuesday, October 22, 2019 4:29 PM
> To: Herbert Xu <herbert@...dor.apana.org.au>; David S. Miller <davem@...emloft.net>
> Cc: Arnd Bergmann <arnd@...db.de>; Antoine Tenart <antoine.tenart@...tlin.com>; Pascal Van
> Leeuwen <pvanleeuwen@...imatrix.com>; Ard Biesheuvel <ard.biesheuvel@...aro.org>; Pascal van
> Leeuwen <pascalvanl@...il.com>; linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3
> 
> Without this symbol, the safexcel driver causes a link error:
> 
> drivers/crypto/inside-secure/safexcel_hash.o: In function `safexcel_ahash_final':
> safexcel_hash.c:(.text+0x3c4): undefined reference to `sm3_zero_message_hash'
> 
> Fixes: 0f2bc13181ce ("crypto: inside-secure - Added support for basic SM3 ahash")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 357e230769c8..1ca8d9a15f2a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL
>  	select CRYPTO_SHA512
>  	select CRYPTO_CHACHA20POLY1305
>  	select CRYPTO_SHA3
> +	select CRYPTO_SM3
>
Was this problem observed with the latest state of the Cryptodev GIT?
Because I already attempted to fix this issue with commit 99a59da3723b9725
Can you please double check if you still get the compile error with that
commit included?
(I can't tell from this mail which version of the sources you are using)

>  	help
>  	  This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
>  	  engines designed by Inside Secure. It currently accelerates DES, 3DES and
> --
> 2.20.0



Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com