linux-kernel - Re: [PATCH] mm: fix comments based on per-node memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022161025.GC21381@tower.DHCP.thefacebook.com>
Date:   Tue, 22 Oct 2019 16:10:30 +0000
From:   Roman Gushchin <guro@...com>
To:     Hao Lee <haolee.swjtu@...il.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "shakeelb@...gle.com" <shakeelb@...gle.com>,
        "mhocko@...nel.org" <mhocko@...nel.org>,
        "chris@...isdown.name" <chris@...isdown.name>,
        "yang.shi@...ux.alibaba.com" <yang.shi@...ux.alibaba.com>,
        "tj@...nel.org" <tj@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: fix comments based on per-node memcg

On Tue, Oct 22, 2019 at 03:06:18PM +0000, Hao Lee wrote:
> These comments should be updated as memcg limit enforcement has been moved
> from zones to nodes.
> 
> Signed-off-by: Hao Lee <haolee.swjtu@...il.com>

Acked-by: Roman Gushchin <guro@...com>

Thanks!

> ---
>  include/linux/memcontrol.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ae703ea3ef48..12c29f74c02a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -112,7 +112,7 @@ struct memcg_shrinker_map {
>  };
>  
>  /*
> - * per-zone information in memory controller.
> + * per-node information in memory controller.
>   */
>  struct mem_cgroup_per_node {
>  	struct lruvec		lruvec;
> @@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
>   * @memcg: memcg of the wanted lruvec
>   *
>   * Returns the lru list vector holding pages for a given @node or a given
> - * @memcg and @zone. This can be the node lruvec, if the memory controller
> - * is disabled.
> + * @memcg. This can be the node lruvec, if the memory controller is disabled.
>   */
>  static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
>  				struct mem_cgroup *memcg)
> -- 
> 2.14.5
>