linux-kernel - Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022162739.GW5610@atomide.com>
Date:   Tue, 22 Oct 2019 09:27:39 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Benoit Parrot <bparrot@...com>
Cc:     Tero Kristo <t-kristo@...com>, Rob Herring <robh+dt@...nel.org>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2
 cameras

* Benoit Parrot <bparrot@...com> [191022 16:17]:
> Tony Lindgren <tony@...mide.com> wrote on Tue [2019-Oct-22 08:44:46 -0700]:
> > * Benoit Parrot <bparrot@...com> [191018 15:46]:
> > > Add device nodes for CSI2 camera board OV5640.
> > > Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> > > 
> > > Signed-off-by: Benoit Parrot <bparrot@...com>
> > > ---
> > >  arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > index 8641a3d7d8ad..e4c01a67f6de 100644
> > > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > @@ -187,6 +187,12 @@
> > >  		gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> > >  		enable-active-high;
> > >  	};
> > > +
> > > +	clk_ov5640_fixed: clk_ov5640_fixed {
> > > +		compatible = "fixed-clock";
> > > +		#clock-cells = <0>;
> > > +		clock-frequency = <24000000>;
> > > +	};
> > >  };
> > 
> > The clock node name should be generic and not use
> > undescores. If there is a hidden dependency to the
> > clock node name here, it should be mentioned in the
> > patch for the non-standard use.
> 
> Not sure what you mean by generic, here.
> This is just to provide a "clock" node which gives the "value" of the fixed
> oscillator frequency so driver can get to it, the actual name does not
> matter.

Oh just something like:

	clk_ov5640_fixed: clock@foo {
		compatible = "fixed-clock";
		#clock-cells = <0>;
		clock-frequency = <24000000>;
	};

Or just clock if the only instance and no reg?

We currently get tons of warnings for TI clocks, that's
thousands of lines because of non-standard naming and
use of undescore instead of dash for the naming.. Let's
not add more.

Regards,

Tony