linux-kernel - Re: [PATCH] xfs: add mising include of xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191022165532.GM913374@magnolia>
Date:   Tue, 22 Oct 2019 09:55:32 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: add mising include of xfs_pnfs.h for missing
 declarations

On Tue, Oct 22, 2019 at 04:32:47PM +0100, Ben Dooks (Codethink) wrote:
> The xfs_pnfs.c file is missing an include of xfs_pnfs.h to
> add the prototypes of the functions it exports. Include this
> file to fix the following sparse warnings:
> 
> fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
> Cc: "Darrick J. Wong" <darrick.wong@...cle.com>
> Cc: linux-xfs@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/xfs/xfs_pnfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
> index a339bd5fa260..b2f6f1e3d9c4 100644
> --- a/fs/xfs/xfs_pnfs.c
> +++ b/fs/xfs/xfs_pnfs.c
> @@ -12,6 +12,7 @@
>  #include "xfs_trans.h"
>  #include "xfs_bmap.h"
>  #include "xfs_iomap.h"
> +#include "xfs_pnfs.h"
>  
>  /*
>   * Ensure that we do not have any outstanding pNFS layouts that can be used by
> -- 
> 2.23.0
>