linux-kernel - Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <710cc020-f411-38ad-a9c4-3f44957645f5@huawei.com>
Date:   Tue, 22 Oct 2019 09:28:40 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     David Laight <David.Laight@...LAB.COM>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "dsahern@...il.com" <dsahern@...il.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "allison@...utok.net" <allison@...utok.net>,
        "mmanning@...tta.att-mail.com" <mmanning@...tta.att-mail.com>,
        "petrm@...lanox.com" <petrm@...lanox.com>,
        "dcaratti@...hat.com" <dcaratti@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when
 setting initial MTU

On 2019/10/21 22:46, David Laight wrote:
> From: Yunsheng Lin
>> Sent: 21 October 2019 13:26
>> Currently the MTU of vlan netdevice is set to the same MTU
>> of the lower device, which requires the underlying device
>> to handle it as the comment has indicated:
>>
>> 	/* need 4 bytes for extra VLAN header info,
>> 	 * hope the underlying device can handle it.
>> 	 */
>> 	new_dev->mtu = real_dev->mtu;
>>
>> Currently most of the physical netdevs seems to handle above
>> by reversing 2 * VLAN_HLEN for L2 packet len.
> 
> s/reverse/reserve/g

Thanks.

> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 
> 
> .
>