linux-kernel - Re: [PATCH v2] panfrost: Properly undo pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKT4f+Bp7Ajg=V-Ejaynp6BXXFUJKNuCxasU3U3LgepDg@mail.gmail.com>
Date:   Wed, 23 Oct 2019 12:58:59 -0500
From:   Rob Herring <robh@...nel.org>
To:     Steven Price <steven.price@....com>
Cc:     Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>, Chen-Yu Tsai <wens@...e.org>,
        Robin Murphy <robin.murphy@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2] panfrost: Properly undo pm_runtime_enable when
 deferring a probe

On Wed, Oct 23, 2019 at 10:49 AM Steven Price <steven.price@....com> wrote:
>
> On 23/10/2019 13:21, Tomeu Vizoso wrote:
> > When deferring the probe because of a missing regulator, we were calling
> > pm_runtime_disable even if pm_runtime_enable wasn't called.
> >
> > Move the call to pm_runtime_disable to the right place.
> >
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> > Reported-by: Chen-Yu Tsai <wens@...e.org>
> > Cc: Robin Murphy <robin.murphy@....com>
> > Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure")
>
> As Robin pointed out this should be:
>
> Fixes: 635430797d3f ("drm/panfrost: Rework runtime PM initialization")
>
> But other than that,
>
> Reviewed-by: Steven Price <steven.price@....com>

Applied with Fixes fixed. Looks like we just missed this weeks fixes...

Rob