linux-kernel - Re: [PATCH v3 0/3] x86/boot: Introduce the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <781feb2e-a4e1-36f8-ba01-a3c6101f5193@zytor.com>
Date:   Wed, 23 Oct 2019 13:44:30 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Daniel Kiper <daniel.kiper@...cle.com>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        xen-devel@...ts.xenproject.org
Cc:     ard.biesheuvel@...aro.org, boris.ostrovsky@...cle.com,
        bp@...en8.de, corbet@....net, dave.hansen@...ux.intel.com,
        luto@...nel.org, peterz@...radead.org, eric.snowberg@...cle.com,
        jgross@...e.com, konrad.wilk@...cle.com, mingo@...hat.com,
        ross.philipson@...cle.com, tglx@...utronix.de,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes

On 2019-10-16 04:06, Daniel Kiper wrote:
> On Wed, Oct 09, 2019 at 12:53:55PM +0200, Daniel Kiper wrote:
>> Hi,
>>
>> Due to very limited space in the setup_header this patch series introduces new
>> kernel_info struct which will be used to convey information from the kernel to
>> the bootloader. This way the boot protocol can be extended regardless of the
>> setup_header limitations. Additionally, the patch series introduces some
>> convenience features like the setup_indirect struct and the
>> kernel_info.setup_type_max field.
>>
>> Daniel
>>
>>  Documentation/x86/boot.rst             | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  arch/x86/boot/Makefile                 |   2 +-
>>  arch/x86/boot/compressed/Makefile      |   4 +-
>>  arch/x86/boot/compressed/kaslr.c       |  12 ++++++
>>  arch/x86/boot/compressed/kernel_info.S |  22 +++++++++++
>>  arch/x86/boot/header.S                 |   3 +-
>>  arch/x86/boot/tools/build.c            |   5 +++
>>  arch/x86/include/uapi/asm/bootparam.h  |  16 +++++++-
>>  arch/x86/kernel/e820.c                 |  11 ++++++
>>  arch/x86/kernel/kdebugfs.c             |  20 ++++++++--
>>  arch/x86/kernel/ksysfs.c               |  30 ++++++++++----
>>  arch/x86/kernel/setup.c                |   4 ++
>>  arch/x86/mm/ioremap.c                  |  11 ++++++
>>  13 files changed, 292 insertions(+), 16 deletions(-)
>>
>> Daniel Kiper (3):
>>       x86/boot: Introduce the kernel_info
>>       x86/boot: Introduce the kernel_info.setup_type_max
>>       x86/boot: Introduce the setup_indirect
> 
> hpa, ping?
> 

Looks really good to me, modulo the feedback Randy already brought up.

Reviewed-by: H. Peter Anvin (Intel) <hpa@...or.com>

	-hpa