linux-kernel - Re: [PATCH v3 5/8] riscv: mark some code and data as file-static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1910231531480.6074@viisi.sifive.com>
Date:   Wed, 23 Oct 2019 15:32:26 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Greentime Hu <green.hu@...il.com>
cc:     Mao Han <han_mao@...ky.com>, Guo Ren <guoren@...nel.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/8] riscv: mark some code and data as file-static

On Wed, 23 Oct 2019, Greentime Hu wrote:

> Paul Walmsley <paul.walmsley@...ive.com> 於 2019年10月19日 週六 下午3:58寫道：
> >
> > Several functions and arrays which are only used in the files in which
> > they are declared are missing "static" qualifiers.  Warnings for these
> > symbols are reported by sparse:
> >
> > arch/riscv/kernel/stacktrace.c:22:14: warning: symbol 'walk_stackframe' was not declared. Should it be static?

[ ... ]

> I think walk_stackframe() could not be static because it will be used
> in perf_callchain.c.

Thanks Greentime - will update the patch.


- Paul