linux-kernel - Re: [PATCH] phy-mvebu-a3700-utmi: Use devm_platform_ioremap_resource() in mvebu_a3700_utmi_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Oct 2019 10:55:12 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Markus Elfring <Markus.Elfring@....de>,
        <kernel-janitors@...r.kernel.org>,
        Igal Liberman <igall@...vell.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>
CC:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy-mvebu-a3700-utmi: Use
 devm_platform_ioremap_resource() in mvebu_a3700_utmi_phy_probe()


On 26/09/19 9:50 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 26 Sep 2019 18:15:23 +0200
> 
> Simplify this function implementation by using a known wrapper function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

merged, thanks!

-Kishon

> ---
>  drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> index ded900b06f5a..23bc3bf5c4c0 100644
> --- a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> @@ -216,20 +216,13 @@ static int mvebu_a3700_utmi_phy_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct mvebu_a3700_utmi *utmi;
>  	struct phy_provider *provider;
> -	struct resource *res;
> 
>  	utmi = devm_kzalloc(dev, sizeof(*utmi), GFP_KERNEL);
>  	if (!utmi)
>  		return -ENOMEM;
> 
>  	/* Get UTMI memory region */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "Missing UTMI PHY memory resource\n");
> -		return -ENODEV;
> -	}
> -
> -	utmi->regs = devm_ioremap_resource(dev, res);
> +	utmi->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(utmi->regs))
>  		return PTR_ERR(utmi->regs);
> 
> --
> 2.23.0
>