linux-kernel - Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191023160403.1bc56772@jacob-builder>
Date:   Wed, 23 Oct 2019 16:04:03 -0700
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     "Raj, Ashok" <ashok.raj@...el.com>
Cc:     iommu@...ts.linux-foundation.org,
        LKML <linux-kernel@...r.kernel.org>,
        Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Yi Liu <yi.l.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Christoph Hellwig <hch@...radead.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Eric Auger <eric.auger@...hat.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID

On Tue, 22 Oct 2019 21:04:00 -0700
Jacob Pan <jacob.jun.pan@...ux.intel.com> wrote:

> > > +		if (cap_caching_mode(iommu->cap) &&
> > > sm_supported(iommu)) {    
> > 
> > do you need to check against cap_caching_mode() or ecap_vcmd?
> >   
> I guess ecap_vcmd() will suffice. Kind of redundant.
Actually, we can check vcmd and vcmd_pasid here, then we dont need to
check it on every alloc/free calls.

Thanks,

Jacob