linux-kernel - Re: [PATCH v2 2/2] HID: google: Add of_match table to Whiskers switch device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191023003054.GY35946@dtor-ws>
Date:   Tue, 22 Oct 2019 17:30:54 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Ikjoon Jang <ikjn@...omium.org>
Cc:     linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org,
        Nicolas Boitchat <drinkcat@...omium.org>
Subject: Re: [PATCH v2 2/2] HID: google: Add of_match table to Whiskers
 switch device.

On Mon, Oct 21, 2019 at 11:02:33AM +0800, Ikjoon Jang wrote:
> Add a device tree match table.
> 
> Signed-off-by: Ikjoon Jang <ikjn@...omium.org>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

> ---
>  drivers/hid/hid-google-hammer.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 84f8c127ebdc..b726f8a15044 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -17,6 +17,7 @@
>  #include <linux/hid.h>
>  #include <linux/leds.h>
>  #include <linux/module.h>
> +#include <linux/of.h>
>  #include <linux/platform_data/cros_ec_commands.h>
>  #include <linux/platform_data/cros_ec_proto.h>
>  #include <linux/platform_device.h>
> @@ -264,12 +265,21 @@ static const struct acpi_device_id cbas_ec_acpi_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(acpi, cbas_ec_acpi_ids);
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id cbas_ec_of_match[] = {
> +	{ .compatible = "google,cros-cbas" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, cbas_ec_of_match);
> +#endif
> +
>  static struct platform_driver cbas_ec_driver = {
>  	.probe = cbas_ec_probe,
>  	.remove = cbas_ec_remove,
>  	.driver = {
>  		.name = "cbas_ec",
>  		.acpi_match_table = ACPI_PTR(cbas_ec_acpi_ids),
> +		.of_match_table = of_match_ptr(cbas_ec_of_match),
>  		.pm = &cbas_ec_pm_ops,
>  	},
>  };

-- 
Dmitry