linux-kernel - Re: [PATCH -next] phy: ti: dm816x: remove set but not used variable 'phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Oct 2019 11:08:03 +0300
From:   Roger Quadros <rogerq@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <kishon@...com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] phy: ti: dm816x: remove set but not used variable
 'phy_data'



On 23/10/2019 10:45, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/phy/ti/phy-dm816x-usb.c:192:29: warning:
>   variable phy_data set but not used [-Wunused-but-set-variable]
> 
> It is never used, so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Roger Quadros <rogerq@...com>

cheers,
-roger

> ---
>   drivers/phy/ti/phy-dm816x-usb.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x-usb.c
> index cbcce7c..26f1947 100644
> --- a/drivers/phy/ti/phy-dm816x-usb.c
> +++ b/drivers/phy/ti/phy-dm816x-usb.c
> @@ -189,7 +189,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
>   	struct phy_provider *phy_provider;
>   	struct usb_otg *otg;
>   	const struct of_device_id *of_id;
> -	const struct usb_phy_data *phy_data;
>   	int error;
>   
>   	of_id = of_match_device(of_match_ptr(dm816x_usb_phy_id_table),
> @@ -220,8 +219,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
>   	if (phy->usbphy_ctrl == 0x2c)
>   		phy->instance = 1;
>   
> -	phy_data = of_id->data;
> -
>   	otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
>   	if (!otg)
>   		return -ENOMEM;
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki