linux-kernel - Re: [PATCH -next] staging: comedi: dt2814: remove set but not used variables 'data'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39229719-55d4-4a71-f698-95ce491496b4@mev.co.uk>
Date:   Wed, 23 Oct 2019 10:06:30 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     YueHaibing <yuehaibing@...wei.com>, hsweeten@...ionengravers.com,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: comedi: dt2814: remove set but not used
 variables 'data'

On 23/10/2019 08:48, YueHaibing wrote:
> drivers/staging/comedi/drivers/dt2814.c:193:6:
>   warning: variable data set but not used [-Wunused-but-set-variable]
> 
> It is never used, so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/staging/comedi/drivers/dt2814.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c
> index d2c7157..e7c6787 100644
> --- a/drivers/staging/comedi/drivers/dt2814.c
> +++ b/drivers/staging/comedi/drivers/dt2814.c
> @@ -186,21 +186,17 @@ static int dt2814_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>   
>   static irqreturn_t dt2814_interrupt(int irq, void *d)
>   {
> -	int lo, hi;
>   	struct comedi_device *dev = d;
>   	struct dt2814_private *devpriv = dev->private;
>   	struct comedi_subdevice *s = dev->read_subdev;
> -	int data;
>   
>   	if (!dev->attached) {
>   		dev_err(dev->class_dev, "spurious interrupt\n");
>   		return IRQ_HANDLED;
>   	}
>   
> -	hi = inb(dev->iobase + DT2814_DATA);
> -	lo = inb(dev->iobase + DT2814_DATA);
> -
> -	data = (hi << 4) | (lo >> 4);
> +	inb(dev->iobase + DT2814_DATA);
> +	inb(dev->iobase + DT2814_DATA);
>   
>   	if (!(--devpriv->ntrig)) {
>   		int i;
> 

Those variables are currently unused due to a bug that I need to fix.


-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-