linux-kernel - Re: [PATCH -next] staging: comedi: remove unused variable 'route_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516d7146-fe16-6d8e-9812-038280c256df@mev.co.uk>
Date:   Wed, 23 Oct 2019 10:07:18 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     YueHaibing <yuehaibing@...wei.com>, hsweeten@...ionengravers.com,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: comedi: remove unused variable
 'route_table_size'

On 23/10/2019 08:52, YueHaibing wrote:
> drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
>   route_table_size defined but not used [-Wunused-const-variable=]
> 
> It is never used since introduction.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/staging/comedi/drivers/ni_routes.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_routes.c b/drivers/staging/comedi/drivers/ni_routes.c
> index eb61494..673d732 100644
> --- a/drivers/staging/comedi/drivers/ni_routes.c
> +++ b/drivers/staging/comedi/drivers/ni_routes.c
> @@ -49,8 +49,6 @@
>   /* Helper for accessing data. */
>   #define RVi(table, src, dest)	((table)[(dest) * NI_NUM_NAMES + (src)])
>   
> -static const size_t route_table_size = NI_NUM_NAMES * NI_NUM_NAMES;
> -
>   /*
>    * Find the proper route_values and ni_device_routes tables for this particular
>    * device.
> 

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-