linux-kernel - Re: [PATCH V2 0/7] Add Fintek F81534A series usb-to-serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191023092144.GR24768@localhost>
Date:   Wed, 23 Oct 2019 11:21:44 +0200
From:   Johan Hovold <johan@...nel.org>
To:     "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        peter_hong@...tek.com.tw,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V2 0/7] Add Fintek F81534A series usb-to-serial driver

On Mon, Sep 23, 2019 at 10:24:42AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The Fintek F81532A/534A/535/536 is USB-to-2/4/8/12 serial ports device
> and the serial port is default disabled when plugin computer.
> 
> The part number is a bit same with F81532/534, but F81534A series UART
> core is enhanced from F81232, not F81532/534.  
> 
> The IC is contains devices as following:
> 	1. HUB (all devices is connected with this hub)
> 	2. GPIO/Control device. (enable serial port and control all GPIOs)
> 	3. serial port 1 to x (2/4/8/12)
> 
> It's most same with F81232, the UART device is difference as follow:
> 	1. TX/RX bulk size is 128/512bytes
> 	2. RX bulk layout change:
> 		F81232: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
> 		F81534A:[LEN][Data.....][LSR]
> 
> We'll try to do some code refacting before add F81534A series.

Make sure to always provide a changelog when sending an updated series
(either here for the entire series or below the --- line in the
individual patches).

What has changed since v1?

> Ji-Ze Hong (Peter Hong) (7):
>   USB: serial: f81232: Extract LSR handler
>   USB: serial: f81232: Add tx_empty function
>   USB: serial: f81232: Use devm_kzalloc
>   USB: serial: f81232: Add F81534A support
>   USB: serial: f81232: Set F81534A serial port with RS232 mode
>   USB: serial: f81232: Add generator for F81534A
>   USB: serial: f81232: Add gpiolib to GPIO device
> 
>  drivers/usb/serial/f81232.c | 604 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 570 insertions(+), 34 deletions(-)

Johan