linux-kernel - Re: [PATCH] kernel-doc: trivial improvement for warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Oct 2019 19:27:11 +0800
From:   Changbin Du <changbin.du@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Changbin Du <changbin.du@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Jiri Kosina <trivial@...nel.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel-doc: trivial improvement for warning message

On Mon, Oct 21, 2019 at 11:54:06AM -0700, Matthew Wilcox wrote:
> On Sun, Oct 20, 2019 at 09:23:23PM +0800, Changbin Du wrote:
> > The message "Function parameter or member ..." looks weird.
> > 
> > Signed-off-by: Changbin Du <changbin.du@...il.com>
> > ---
> >  scripts/kernel-doc | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> > index 81dc91760b23..cd3d2ca52c34 100755
> > --- a/scripts/kernel-doc
> > +++ b/scripts/kernel-doc
> > @@ -1475,8 +1475,13 @@ sub push_parameter($$$$) {
> >  		$parameterdescs{$param} = $undescribed;
> >  
> >  	        if (show_warnings($type, $declaration_name) && $param !~ /\./) {
> > -			print STDERR
> > -			      "${file}:$.: warning: Function parameter or member '$param' not described in '$declaration_name'\n";
> > +			if ($decl_type eq "struct" or $decl_type eq 'union') {
> > +				print STDERR
> > +					"${file}:$.: warning: $decl_type member '$param' not described in '$declaration_name'\n";
> > +			} else {
> > +				print STDERR
> > +					"${file}:$.: warning: $decl_type parameter '$param' not described in '$declaration_name'\n";
> > +			}
> >  			++$warnings;
> 
> How about instead ...
> 
> 		if (show_warnings($type, $declaration_name) && $param !~ /\./) {			if ($decl_type eq "struct")
> 				$msg = "struct member";
> 			elif ($decl_type eq "union")
> 				$msg = "union member";
> 			else
> 				$msg = "function parameter";
> 			print STDERR "${file}:$.: warning: $msg '$param' not described in '$declaration_name'\n";
> 
> (please excuse my perl, i am not a native speaker)
This removes some duplicated characters, but need to decalare a extra variable.
I am okay for both approaches. :)

-- 
Cheers,
Changbin Du