linux-kernel - Re: [PATCH v2] panfrost: Properly undo pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6952956c-ba58-71de-05c9-fa39333484d9@arm.com>
Date:   Wed, 23 Oct 2019 13:49:59 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        linux-kernel@...r.kernel.org
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2] panfrost: Properly undo pm_runtime_enable when
 deferring a probe

On 2019-10-23 1:21 pm, Tomeu Vizoso wrote:
> When deferring the probe because of a missing regulator, we were calling
> pm_runtime_disable even if pm_runtime_enable wasn't called.
> 
> Move the call to pm_runtime_disable to the right place.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Reported-by: Chen-Yu Tsai <wens@...e.org>
> Cc: Robin Murphy <robin.murphy@....com>
> Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure")

I think that commit was right at the time, but actually we missed 
reordering the cleanup path to match the change in 635430797d3f. 
Otherwise, though,

Reviewed-by: Robin Murphy <robin.murphy@....com>

> ---
>   drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index bc2ddeb55f5d..f21bc8a7ee3a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -556,11 +556,11 @@ static int panfrost_probe(struct platform_device *pdev)
>   	return 0;
>   
>   err_out2:
> +	pm_runtime_disable(pfdev->dev);
>   	panfrost_devfreq_fini(pfdev);
>   err_out1:
>   	panfrost_device_fini(pfdev);
>   err_out0:
> -	pm_runtime_disable(pfdev->dev);
>   	drm_dev_put(ddev);
>   	return err;
>   }
>