linux-kernel - Re: [PATCH v6 00/10] Nested Shared Virtual Address (SVA) VT-d support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191023064600.5e24234b@jacob-builder>
Date:   Wed, 23 Oct 2019 06:46:00 -0700
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     "Raj, Ashok" <ashok.raj@...el.com>
Cc:     iommu@...ts.linux-foundation.org,
        LKML <linux-kernel@...r.kernel.org>,
        Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Yi Liu <yi.l.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Christoph Hellwig <hch@...radead.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Eric Auger <eric.auger@...hat.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v6 00/10] Nested Shared Virtual Address (SVA) VT-d
 support

On Tue, 22 Oct 2019 17:27:51 -0700
"Raj, Ashok" <ashok.raj@...el.com> wrote:

> Hi Jacob
> 
> On Tue, Oct 22, 2019 at 04:53:13PM -0700, Jacob Pan wrote:
> > Shared virtual address (SVA), a.k.a, Shared virtual memory (SVM) on
> > Intel platforms allow address space sharing between device DMA and
> > applications. SVA can reduce programming complexity and enhance
> > security. This series is intended to enable SVA virtualization,
> > i.e. shared guest application address space and physical device DMA
> > address. Only IOMMU portion  
> 
> Last line "i.e shared guest application address space and physical
> device DMA address" doesn't read well. 
> 
> Simply rephrase as "enable use of SVA within a guest user application"
> 
Much better, thanks!
> > of the changes are included in this series. Additional support is
> > needed in VFIO and QEMU (will be submitted separately) to complete
> > this functionality.
> > 
> > To make incremental changes and reduce the size of each patchset.
> > This series does not inlcude support for page request services.
> > 
> > In VT-d implementation, PASID table is per device and maintained in
> > the host. Guest PASID table is shadowed in VMM where virtual IOMMU
> > is emulated.
> > 
> >     .-------------.  .---------------------------.
> >     |   vIOMMU    |  | Guest process CR3, FL only|
> >     |             |  '---------------------------'
> >     .----------------/
> >     | PASID Entry |--- PASID cache flush -
> >     '-------------'                       |
> >     |             |                       V
> >     |             |                CR3 in GPA
> >     '-------------'
> > Guest
> > ------| Shadow |--------------------------|--------
> >       v        v                          v
> > Host
> >     .-------------.  .----------------------.
> >     |   pIOMMU    |  | Bind FL for GVA-GPA  |
> >     |             |  '----------------------'
> >     .----------------/  |
> >     | PASID Entry |     V (Nested xlate)
> >     '----------------\.------------------------------.
> >     |             |   |SL for GPA-HPA, default domain|
> >     |             |   '------------------------------'
> >     '-------------'  
> 
> is the SL for GPA-HPA default domain? When you assign a device to 
> Guest, this isn't default domain right?
> 
SL is harvested from default domain for PCI device assignment. Once we
add mdev support, you are right that SL is not default domain, but this
patchset is not dealing with mdev yet. Jumping ahead :)

> > Where:
> >  - FL = First level/stage one page tables
> >  - SL = Second level/stage two page tables
> > 
> > This is the remaining VT-d only portion of V5 since the uAPIs and
> > IOASID common code have been applied to Joerg's IOMMU core branch.
> > (https://lkml.org/lkml/2019/10/2/833)
> > 
> > The complete set with VFIO patches are here:
> > https://github.com/jacobpan/linux.git:siov_sva
> > 
> > The complete nested SVA upstream patches are divided into three
> > phases: 1. Common APIs and PCI device direct assignment
> >     2. Page Request Services (PRS) support
> >     3. Mediated device assignment
> > 
> > With this set and the accompanied VFIO code, we will achieve phase
> > #1.
> > 
> > Thanks,
> > 
> > Jacob
> > 
> > ChangeLog:
> > 	- V6
> > 	  - Rebased on top of Joerg's core branch
> > 	  (git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git
> > core)
> > 	  - Adapt to new uAPIs and IOASID allocators
> > 
> > 	- V5
> > 	  Rebased on v5.3-rc4 which has some of the IOMMU fault
> > APIs merged. Addressed v4 review comments from Eric Auger, Baolu
> > Lu, and Jonathan Cameron. Specific changes are as follows:
> > 	  - Refined custom IOASID allocator to support multiple
> > vIOMMU, hotplug cases.
> > 	  - Extracted vendor data from IOMMU guest PASID bind data,
> > for VT-d will support all necessary guest PASID entry fields for
> > PASID bind.
> > 	  - Support non-identity host-guest PASID mapping
> > 	  - Exception handling in various cases
> > 
> > 	- V4
> > 	  - Redesigned IOASID allocator such that it can support
> > custom allocators with shared helper functions. Use separate XArray
> > 	  to store IOASIDs per allocator. Took advice from Eric
> > Auger to have default allocator use the generic allocator structure.
> > 	  Combined into one patch in that the default allocator is
> > just "another" allocator now. Can be built as a module in case of
> > 	  driver use without IOMMU.
> > 	  - Extended bind guest PASID data to support SMMU and
> > non-identity guest to host PASID mapping
> > https://lkml.org/lkml/2019/5/21/802
> > 	  - Rebased on Jean's sva/api common tree, new patches
> > starts with [PATCH v4 10/22]
> > 
> > 	- V3
> > 	  - Addressed thorough review comments from Eric Auger
> > (Thank you!)
> > 	  - Moved IOASID allocator from driver core to IOMMU code
> > per suggestion by Christoph Hellwig
> > 	    (https://lkml.org/lkml/2019/4/26/462)
> > 	  - Rebased on top of Jean's SVA API branch and Eric's v7[1]
> > 	    (git://linux-arm.org/linux-jpb.git sva/api)
> > 	  - All IOMMU APIs are unmodified (except the new bind
> > guest PASID call in patch 9/16)
> > 
> > 	- V2
> > 	  - Rebased on Joerg's IOMMU x86/vt-d branch v5.1-rc4
> > 	  - Integrated with Eric Auger's new v7 series for common
> > APIs (https://github.com/eauger/linux/tree/v5.1-rc3-2stage-v7)
> > 	  - Addressed review comments from Andy Shevchenko and Alex
> > Williamson on IOASID custom allocator.
> > 	  - Support multiple custom IOASID allocators (vIOMMUs) and
> > dynamic registration.
> > 
> > 
> > Jacob Pan (9):
> >   iommu/vt-d: Add custom allocator for IOASID
> >   iommu/vt-d: Replace Intel specific PASID allocator with IOASID
> >   iommu/vt-d: Move domain helper to header
> >   iommu/vt-d: Avoid duplicated code for PASID setup
> >   iommu/vt-d: Add nested translation helper function
> >   iommu/vt-d: Misc macro clean up for SVM
> >   iommu/vt-d: Add bind guest PASID support
> >   iommu/vt-d: Support flushing more translation cache types
> >   iommu/vt-d: Add svm/sva invalidate function
> > 
> > Lu Baolu (1):
> >   iommu/vt-d: Enlightened PASID allocation
> > 
> >  drivers/iommu/Kconfig       |   1 +
> >  drivers/iommu/dmar.c        |  46 ++++++
> >  drivers/iommu/intel-iommu.c | 259 +++++++++++++++++++++++++++++++--
> >  drivers/iommu/intel-pasid.c | 343
> > +++++++++++++++++++++++++++++++++++++-------
> > drivers/iommu/intel-pasid.h |  25 +++- drivers/iommu/intel-svm.c
> > | 298 ++++++++++++++++++++++++++++++--------
> > include/linux/intel-iommu.h |  39 ++++- include/linux/intel-svm.h
> > |  17 +++ 8 files changed, 904 insertions(+), 124 deletions(-)
> > 
> > -- 
> > 2.7.4
> >   

[Jacob Pan]