linux-kernel - Re: [PATCH] mm/page_alloc: fix gcc compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Oct 2019 15:44:56 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Chen Wandun <chenwandun@...wei.com>, akpm@...ux-foundation.org,
        mhocko@...e.com, vbabka@...e.cz, osalvador@...e.de,
        mgorman@...hsingularity.net, rppt@...ux.ibm.com,
        dan.j.williams@...el.com, alexander.h.duyck@...ux.intel.com,
        anshuman.khandual@....com, pavel.tatashin@...rosoft.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc: fix gcc compile warning

On 23.10.19 15:48, Chen Wandun wrote:
> From: Chenwandun <chenwandun@...wei.com>
> 
> mm/page_alloc.o: In function `page_alloc_init_late':
> mm/page_alloc.c:1956: undefined reference to `zone_pcp_update'
> mm/page_alloc.o:(.debug_addr+0x8350): undefined reference to `zone_pcp_update'
> make: *** [vmlinux] Error 1
> 
> zone_pcp_update is defined in CONFIG_MEMORY_HOTPLUG,
> so add ifdef when calling zone_pcp_update.
> 
> Signed-off-by: Chenwandun <chenwandun@...wei.com>
> ---
>  mm/page_alloc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f9488ef..8513150 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1952,8 +1952,10 @@ void __init page_alloc_init_late(void)
>  	 * so the pcpu batch and high limits needs to be updated or the limits
>  	 * will be artificially small.
>  	 */
> +#ifdef CONFIG_MEMORY_HOTPLUG
>  	for_each_populated_zone(zone)
>  		zone_pcp_update(zone);
> +#endif
>  
>  	/*
>  	 * We initialized the rest of the deferred pages.  Permanently disable
> 

See

https://lkml.org/lkml/2019/10/23/206

-- 

Thanks,

David / dhildenb