linux-kernel - Re: [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2dc38508-b7af-b5bf-2829-52c75514e499@web.de>
Date:   Wed, 23 Oct 2019 16:08:45 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <julia.lawall@...6.fr>, cocci@...teme.lip6.fr
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Cheng Shengyu <cheng.shengyu@....com.cn>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Yi Wang <wang.yi59@....com.cn>,
        Xue Zhihong <xue.zhihong@....com.cn>,
        zhongshiqi <zhong.shiqi@....com.cn>
Subject: Re: [PATCH] coccicheck: Configuring COCCI parameter for supporting a
 directory search

> What is the relation between the last two if branches?

A small addition is proposed for this bash script.

> If the first one fails, does that mean that $COCCI has no definition?

No. - It was checked if an empty sting was passed.
A file system check is tried then to determine if a valid directory was specified.
This parameter could be used then for the specification of a specific start
directory for calling the tool “find”, couldn't it?

> In that case, is the final else useful?

Hopefully, yes.

Which software behaviour do you expect for a string which would not
be recognised as an usable directory in a specific moment
during script execution?

Regards,
Markus