linux-kernel - RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D53702B8F0ACD34B9B1D7D82EE03C045078535F3@PGSMSX101.gar.corp.intel.com>
Date:   Wed, 23 Oct 2019 14:17:02 +0000
From:   "Ooi, Joyce" <joyce.ooi@...el.com>
To:     Dinh Nguyen <dinguyen@...nel.org>,
        Vladimir Murzin <vladimir.murzin@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>
CC:     Shawn Guo <shawnguo@...nel.org>, Olof Johansson <olof@...om.net>,
        "Maxime Ripard" <mripard@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Jagan Teki <jagan@...rulasolutions.com>,
        "Anson Huang" <Anson.Huang@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Ong, Hean Loong" <hean.loong.ong@...el.com>,
        "See, Chin Liang" <chin.liang.see@...el.com>,
        "Tan, Ley Foon" <ley.foon.tan@...el.com>
Subject: RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig



> -----Original Message-----
> From: Dinh Nguyen <dinguyen@...nel.org>
> Sent: Monday, October 21, 2019 11:57 PM
> To: Ooi, Joyce <joyce.ooi@...el.com>; Vladimir Murzin
> <vladimir.murzin@....com>; Catalin Marinas <catalin.marinas@....com>; Will
> Deacon <will@...nel.org>
> Cc: Shawn Guo <shawnguo@...nel.org>; Olof Johansson <olof@...om.net>;
> Maxime Ripard <mripard@...nel.org>; Bjorn Andersson
> <bjorn.andersson@...aro.org>; Arnd Bergmann <arnd@...db.de>; Jagan Teki
> <jagan@...rulasolutions.com>; Anson Huang <Anson.Huang@....com>;
> Leonard Crestez <leonard.crestez@....com>; Marcin Juszkiewicz
> <marcin.juszkiewicz@...aro.org>; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Ong, Hean Loong <hean.loong.ong@...el.com>; See,
> Chin Liang <chin.liang.see@...el.com>; Tan, Ley Foon
> <ley.foon.tan@...el.com>
> Subject: Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
> 
> 
> 
> On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@...el.com>
> > ---
> > v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y  #
> CONFIG_DEBUG_PREEMPT is
> > not set  # CONFIG_FTRACE is not set  CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> >
> 
> Can you explain why you're removing
> CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?
Removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS will fix errors like this:
[ 1.905772] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f90: 0x00bf instead 
[ 1.915275] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f94: 0x6abb instead

I'll add this explanation in the commit message.
> 
> Dinh