linux-kernel - Re: [PATCH v6 1/2] dt-bindings: edac: arm-dmc520.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJxcUr06+O_Ht5Kw0KXCWfSVC+6WMQqNxt-JehHh874hw@mail.gmail.com>
Date:   Wed, 23 Oct 2019 10:37:38 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Lei Wang <leiwang_git@...look.com>
Cc:     "bp@...en8.de" <bp@...en8.de>,
        "james.morse@....com" <james.morse@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "hangl@...rosoft.com" <hangl@...rosoft.com>,
        "lewan@...rosoft.com" <lewan@...rosoft.com>,
        "ruizhao@...rosoft.com" <ruizhao@...rosoft.com>,
        "scott.branden@...adcom.com" <scott.branden@...adcom.com>,
        "yuqing.shen@...adcom.com" <yuqing.shen@...adcom.com>,
        "ray.jui@...adcom.com" <ray.jui@...adcom.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: edac: arm-dmc520.txt

On Thu, Sep 19, 2019 at 1:37 PM Lei Wang <leiwang_git@...look.com> wrote:
>
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>
> Signed-off-by: Lei Wang <leiwang_git@...look.com>
> Reviewed-by: James Morse <james.morse@....com>
>
> ---
>     No change in v6.
> ---
>  .../devicetree/bindings/edac/arm-dmc520.txt   | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/edac/arm-dmc520.txt
>
> diff --git a/Documentation/devicetree/bindings/edac/arm-dmc520.txt b/Documentation/devicetree/bindings/edac/arm-dmc520.txt
> new file mode 100644
> index 000000000000..71e7aa32971a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/arm-dmc520.txt
> @@ -0,0 +1,26 @@
> +* ARM DMC-520 EDAC node
> +
> +Required properties:
> +- compatible           : "brcm,dmc-520", "arm,dmc-520".
> +- reg                  : Address range of the DMC-520 registers.
> +- interrupts           : DMC-520 interrupt numbers. The example below specifies
> +                         two interrupt lines for dram_ecc_errc_int and
> +                         dram_ecc_errd_int.
> +- interrupt-config     : This is an array of interrupt masks. For each of the

Not a standard property, so would need a vendor prefix...

> +                         above interrupt line, add one interrupt mask element to
> +                         it. That is, there is a 1:1 mapping from each interrupt
> +                         line to an interrupt mask. An interrupt mask can represent
> +                         multiple interrupts being enabled. Refer to interrupt_control
> +                         register in DMC-520 TRM for interrupt mapping. In the example
> +                         below, the interrupt configuration enables dram_ecc_errc_int
> +                         and dram_ecc_errd_int. And each interrupt is connected to
> +                         a separate interrupt line.

I've gone and read thru the TRM some. This binding doesn't seem to
correspond to the TRM at all. There are a bunch of interrupts and a
combined interrupt, and then there's the same set for 'overflow'
interrupts.

There's only one 'interrupt_control' reg. How do you have more that 1
32-bit value?

> +
> +Example:
> +
> +dmc0: dmc@...000 {
> +       compatible = "brcm,dmc-520", "arm,dmc-520";
> +       reg = <0x200000 0x80000>;
> +       interrupts = <0x0 0x349 0x4>, <0x0 0x34B 0x4>;
> +       interrupt-config = <0x4>, <0x8>;
> +};
> --
> 2.17.1
>