linux-kernel - Re: [PATCH v2] usbip: Fix free of unallocated memory in vhci tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c3acd02-9687-80fb-27c9-d64d7932b7ab@kernel.org>
Date:   Wed, 23 Oct 2019 09:55:15 -0600
From:   shuah <shuah@...nel.org>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Suwan Kim <suwan.kim027@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, valentina.manea.m@...il.com,
        kbuild test robot <lkp@...el.com>, shuah <shuah@...nel.org>
Subject: Re: [PATCH v2] usbip: Fix free of unallocated memory in vhci tx

On 10/22/19 3:51 AM, Julia Lawall wrote:
> 
> 
> On Tue, 22 Oct 2019, Suwan Kim wrote:
> 
>> iso_buffer should be set to NULL after use and free in the while loop.
>> In the case of isochronous URB in the while loop, iso_buffer is
>> allocated and after sending it to server, buffer is deallocated. And
>> then, if the next URB in the while loop is not a isochronous pipe,
>> iso_buffer still holds the previously deallocated buffer address and
>> kfree tries to free wrong buffer address.
>>
>> Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Reported-by: Julia Lawall <julia.lawall@...6.fr>
>> Signed-off-by: Suwan Kim <suwan.kim027@...il.com>
> 
> Reviewed-by: Julia Lawall <julia.lawall@...6.fr>
> 
>> ---
>> v1 - v2: Move the setting NULL after kfree() and add the comment
>> ---

Thanks.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah