linux-kernel - Re: [PATCH v2] clk: ti: dra7-atl-clock: Remove ti_clk_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0770a061-c731-dfee-0de7-c16dcf87454e@ti.com>
Date:   Thu, 24 Oct 2019 10:59:47 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <mturquette@...libre.com>
CC:     <sboyd@...nel.org>, <linux-omap@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call

On 02/10/2019 11:34, Peter Ujfalusi wrote:
> ti_clk_register() calls it already so the driver should not create
> duplicated alias.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> Hi,
> 
> changes since v1:
> - removed unused ret variable
> 

Queued up for 5.4 fixes, thanks.

-Tero


> Regards,
> Peter
> 
>   drivers/clk/ti/clk-dra7-atl.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index a01ca9395179..f65e16c4f3c4 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -174,7 +174,6 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
>   	struct clk_init_data init = { NULL };
>   	const char **parent_names = NULL;
>   	struct clk *clk;
> -	int ret;
>   
>   	clk_hw = kzalloc(sizeof(*clk_hw), GFP_KERNEL);
>   	if (!clk_hw) {
> @@ -207,11 +206,6 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
>   	clk = ti_clk_register(NULL, &clk_hw->hw, node->name);
>   
>   	if (!IS_ERR(clk)) {
> -		ret = ti_clk_add_alias(NULL, clk, node->name);
> -		if (ret) {
> -			clk_unregister(clk);
> -			goto cleanup;
> -		}
>   		of_clk_add_provider(node, of_clk_src_simple_get, clk);
>   		kfree(parent_names);
>   		return;
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki