linux-kernel - Re: [PATCH] x86: Add trace points to (nearly) all vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Oct 2019 16:38:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     kbuild-all@...ts.01.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] x86: Add trace points to (nearly) all vectors

Hi Andi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[cannot apply to v5.4-rc4 next-20191023]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andi-Kleen/x86-Add-trace-points-to-nearly-all-vectors/20191024-145326
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a5b576bfb3ba85d3e356f9900dce1428d4760582
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/kernel/kvm.c: In function 'do_async_page_fault':
>> arch/x86/kernel/kvm.c:250:2: error: implicit declaration of function 'trace_async_page_fault_entry'; did you mean 'do_async_page_fault'? [-Werror=implicit-function-declaration]
     trace_async_page_fault_entry(0);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
     do_async_page_fault
>> arch/x86/kernel/kvm.c:269:2: error: implicit declaration of function 'trace_async_page_fault_exit'; did you mean 'do_async_page_fault'? [-Werror=implicit-function-declaration]
     trace_async_page_fault_exit(0);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
     do_async_page_fault
   cc1: some warnings being treated as errors

vim +250 arch/x86/kernel/kvm.c

   244	
   245	dotraplinkage void
   246	do_async_page_fault(struct pt_regs *regs, unsigned long error_code, unsigned long address)
   247	{
   248		enum ctx_state prev_state;
   249	
 > 250		trace_async_page_fault_entry(0);
   251	
   252		switch (kvm_read_and_reset_pf_reason()) {
   253		default:
   254			do_page_fault(regs, error_code, address);
   255			break;
   256		case KVM_PV_REASON_PAGE_NOT_PRESENT:
   257			/* page is swapped out by the host. */
   258			prev_state = exception_enter();
   259			kvm_async_pf_task_wait((u32)address, !user_mode(regs));
   260			exception_exit(prev_state);
   261			break;
   262		case KVM_PV_REASON_PAGE_READY:
   263			rcu_irq_enter();
   264			kvm_async_pf_task_wake((u32)address);
   265			rcu_irq_exit();
   266			break;
   267		}
   268	
 > 269		trace_async_page_fault_exit(0);
   270	}
   271	NOKPROBE_SYMBOL(do_async_page_fault);
   272	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (70206 bytes)