linux-kernel - [PATCH] v4l2-compliance: Allow all the selection targets for subdevs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 24 Oct 2019 10:43:08 +0200
From:   Ricardo Ribalda Delgado <ribalda@...nel.org>
To:     hverkuil-cisco@...all.nl, sakari.ailus@...ux.intel.com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Ricardo Ribalda Delgado <ribalda@...nel.org>
Subject: [PATCH] v4l2-compliance: Allow all the selection targets for subdevs

Subdev can also have non-active pixels, and using the _DEFAULT targets
we can capture only the active pixels.

Signed-off-by: Ricardo Ribalda Delgado <ribalda@...nel.org>
---
 utils/v4l2-compliance/v4l2-test-subdevs.cpp | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/utils/v4l2-compliance/v4l2-test-subdevs.cpp b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
index 29987b31..e4923180 100644
--- a/utils/v4l2-compliance/v4l2-test-subdevs.cpp
+++ b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
@@ -388,20 +388,19 @@ int testSubDevFormat(struct node *node, unsigned which, unsigned pad)
 
 struct target_info {
 	__u32 target;
-	bool allowed;
 	bool readonly;
 	bool found;
 };
 
 static target_info targets[] = {
-	{ V4L2_SEL_TGT_CROP, true },
-	{ V4L2_SEL_TGT_CROP_DEFAULT, false, true },
-	{ V4L2_SEL_TGT_CROP_BOUNDS, true, true },
-	{ V4L2_SEL_TGT_NATIVE_SIZE, true },
-	{ V4L2_SEL_TGT_COMPOSE, true },
-	{ V4L2_SEL_TGT_COMPOSE_DEFAULT, false, true },
-	{ V4L2_SEL_TGT_COMPOSE_BOUNDS, true, true },
-	{ V4L2_SEL_TGT_COMPOSE_PADDED, false, true },
+	{ V4L2_SEL_TGT_CROP },
+	{ V4L2_SEL_TGT_CROP_DEFAULT, true },
+	{ V4L2_SEL_TGT_CROP_BOUNDS, true },
+	{ V4L2_SEL_TGT_NATIVE_SIZE },
+	{ V4L2_SEL_TGT_COMPOSE },
+	{ V4L2_SEL_TGT_COMPOSE_DEFAULT, true },
+	{ V4L2_SEL_TGT_COMPOSE_BOUNDS, true },
+	{ V4L2_SEL_TGT_COMPOSE_PADDED, true },
 	{ ~0U },
 };
 
@@ -447,7 +446,6 @@ int testSubDevSelection(struct node *node, unsigned which, unsigned pad)
 		if (ret)
 			continue;
 		have_sel = true;
-		fail_on_test(!targets[tgt].allowed);
 		fail_on_test(check_0(sel.reserved, sizeof(sel.reserved)));
 		fail_on_test(sel.which != which);
 		fail_on_test(sel.pad != pad);
-- 
2.23.0