linux-kernel - Re: [f2fs-dev] [bug report] compiler warning: fs/f2fs/node.c: In function ‘__set_nat_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e815981a-50ef-0f49-cab6-e510ea44ddc0@huawei.com>
Date:   Thu, 24 Oct 2019 17:12:58 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "jaegeuk@...nel.org" <jaegeuk@...nel.org>
Subject: Re: [f2fs-dev] [bug report] compiler warning: fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’: ‘head’ may be used uninitialized

On 2019/10/23 22:02, Ardelean, Alexandru wrote:
> Seems to have been introduced via:
> 
> ----------------------------------------------------------------
> 
> commit 780de47cf6cb5f524cd98ec8ffbffc3da5696e17
> Author: Chao Yu <yuchao0@...wei.com>
> Date:   Tue Mar 20 23:08:30 2018 +0800
> 
>     f2fs: don't track new nat entry in nat set
>     
>     Nat entry set is used only in checkpoint(), and during checkpoint() we
>     won't flush new nat entry with unallocated address, so we don't need to
>     add new nat entry into nat set, then nat_entry_set::entry_cnt can
>     indicate actual entry count we need to flush in checkpoint().
>     
>     Signed-off-by: Yunlei He <heyunlei@...wei.com>
>     Signed-off-by: Chao Yu <yuchao0@...wei.com>
>     Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ----------------------------------------------------------------
> 
> Compiler warning is:
> ----------------------------------------------------------------
> 
>   CC      fs/f2fs/node.o
> In file included from ./include/linux/wait.h:7:0,
>                  from ./include/linux/wait_bit.h:8,
>                  from ./include/linux/fs.h:6,
>                  from fs/f2fs/node.c:11:
> fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’:
> ./include/linux/list.h:63:13: error: ‘head’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
>   next->prev = new;
>              ^
> fs/f2fs/node.c:238:24: note: ‘head’ was declared here
>   struct nat_entry_set *head;

That's not correct, @head will only be assigned and used if new_ne equals NULL.

Thanks,

>                         ^
> cc1: all warnings being treated as errors
> ----------------------------------------------------------------
> 
> Thanks
> Alex
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>