linux-kernel - Re: [PATCH v2 12/15] KVM: Provide common implementation for generic dirty log functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201910241857.TUdom4Lu%lkp@intel.com>
Date:   Thu, 24 Oct 2019 18:28:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     kbuild-all@...ts.01.org, James Hogan <jhogan@...nel.org>,
        Paul Mackerras <paulus@...abs.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Marc Zyngier <maz@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        James Morse <james.morse@....com>,
        Julien Thierry <julien.thierry.kdev@...il.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        linux-mips@...r.kernel.org, kvm-ppc@...r.kernel.org,
        kvm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.cs.columbia.edu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/15] KVM: Provide common implementation for generic
 dirty log functions

Hi Sean,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sean-Christopherson/KVM-Dynamically-size-memslot-arrays/20191024-144336
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: mips-malta_kvm_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/mips/kvm/mips.c: In function 'kvm_arch_dirty_log_tlb_flush':
>> arch/mips/kvm/mips.c:976:48: error: 'memslot' undeclared (first use in this function); did you mean 'memset'?
     kvm_mips_callbacks->flush_shadow_memslot(kvm, memslot);
                                                   ^~~~~~~
                                                   memset
   arch/mips/kvm/mips.c:976:48: note: each undeclared identifier is reported only once for each function it appears in

vim +976 arch/mips/kvm/mips.c

669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal          2012-11-21  972  
3e2c881a0e3a6e arch/mips/kvm/mips.c     Sean Christopherson 2019-10-21  973  void kvm_arch_dirty_log_tlb_flush(struct kvm *kvm, struct kvm_memory_slot *slot)
2a31b9db153530 arch/mips/kvm/mips.c     Paolo Bonzini       2018-10-23  974  {
2a31b9db153530 arch/mips/kvm/mips.c     Paolo Bonzini       2018-10-23  975  	/* Let implementation handle TLB/GVA invalidation */
2a31b9db153530 arch/mips/kvm/mips.c     Paolo Bonzini       2018-10-23 @976  	kvm_mips_callbacks->flush_shadow_memslot(kvm, memslot);
2a31b9db153530 arch/mips/kvm/mips.c     Paolo Bonzini       2018-10-23  977  }
2a31b9db153530 arch/mips/kvm/mips.c     Paolo Bonzini       2018-10-23  978  

:::::: The code at line 976 was first introduced by commit
:::::: 2a31b9db153530df4aa02dac8c32837bf5f47019 kvm: introduce manual dirty log reprotect

:::::: TO: Paolo Bonzini <pbonzini@...hat.com>
:::::: CC: Paolo Bonzini <pbonzini@...hat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (20625 bytes)