linux-kernel - Re: [RFC PATCH 1/5] crypto: ccp - rename psp-dev files to sev-dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e474bce6-8189-2c47-f61c-3c57532a43fd@amd.com>
Date:   Thu, 24 Oct 2019 11:19:37 +0000
From:   "Thomas, Rijo-john" <Rijo-john.Thomas@....com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "Hook, Gary" <Gary.Hook@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Singh, Brijesh" <brijesh.singh@....com>,
        "Easow, Nimesh" <Nimesh.Easow@....com>,
        "Rangasamy, Devaraj" <Devaraj.Rangasamy@....com>
Subject: Re: [RFC PATCH 1/5] crypto: ccp - rename psp-dev files to sev-dev

Hello Ard,

On 23/10/19 5:18 PM, Ard Biesheuvel wrote:
> Hello Thomas,
> 
> On Wed, 23 Oct 2019 at 13:27, Thomas, Rijo-john
> <Rijo-john.Thomas@....com> wrote:
>>
>> This is a preliminary patch for creating a generic PSP device driver
>> file, which will have support for both SEV and TEE (Trusted Execution
>> Environment) interface.
>>
>> This patch does not introduce any new functionality, but simply renames
>> psp-dev.c and psp-dev.h files to sev-dev.c and sev-dev.h files
>> respectively.
>>
>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@....com>
>> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
> 
> This is not the correct way to credit a co-author.
> 
> You are sending the patch, so your signoff should come last.
> 
> If Devaraj is a co-author of this work, you should add the following
> lines *before* your signoff
> 
> Co-authored-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
> 
> If Devaraj is the sole author of this work, and you are just sending
> it out, you should set the authorship on the patch to Devaraj (so it
> will be From: Devaraj Rangasamy <Devaraj.Rangasamy@....com>)
> 

Okay, in my next patch revision I shall correct this.
Devaraj is the co-author.

So, the lines would like like:

Co-authored-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
Signed-off-by: Rijo Thomas <Rijo-john.Thomas@....com>

>> ---
>>  drivers/crypto/ccp/Makefile  |    2 +-
>>  drivers/crypto/ccp/psp-dev.c | 1087 ------------------------------------------
>>  drivers/crypto/ccp/psp-dev.h |   66 ---
>>  drivers/crypto/ccp/sev-dev.c | 1087 ++++++++++++++++++++++++++++++++++++++++++
>>  drivers/crypto/ccp/sev-dev.h |   66 +++
>>  drivers/crypto/ccp/sp-pci.c  |    2 +-
>>  6 files changed, 1155 insertions(+), 1155 deletions(-)
>>  delete mode 100644 drivers/crypto/ccp/psp-dev.c
>>  delete mode 100644 drivers/crypto/ccp/psp-dev.h
>>  create mode 100644 drivers/crypto/ccp/sev-dev.c
>>  create mode 100644 drivers/crypto/ccp/sev-dev.h
>>
> 
> Please regenerate the patch so that the rename is reflected in the diffstat.
> 

Okay, I will regenerate the patch with proper diffstat.

Thanks,
Rijo