linux-kernel - Re: [PATCH v2] [trivial] perf: Spelling s/EACCESS/EACCES/, s/privilidge/privilege/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191024123106.GE4300@lakrids.cambridge.arm.com>
Date:   Thu, 24 Oct 2019 13:31:07 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [trivial] perf: Spelling s/EACCESS/EACCES/,
 s/privilidge/privilege/

On Thu, Oct 24, 2019 at 02:29:04PM +0200, Geert Uytterhoeven wrote:
> As per POSIX, the correct spelling of the error code is EACCES:
> 
> include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Looks sane to me; brings the documentation into line with reality given
EACCESS doesn't exist in tree.

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
> v2:
>   - Add POSIX reference,
>   - Also correct privilidges in the same line.
> ---
>  include/linux/perf_event.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 61448c19a132c29c..68ccc5b1913b485b 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -292,7 +292,7 @@ struct pmu {
>  	 *  -EBUSY	-- @event is for this PMU but PMU temporarily unavailable
>  	 *  -EINVAL	-- @event is for this PMU but @event is not valid
>  	 *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
> -	 *  -EACCESS	-- @event is for this PMU, @event is valid, but no privilidges
> +	 *  -EACCES	-- @event is for this PMU, @event is valid, but no privileges
>  	 *
>  	 *  0		-- @event is for this PMU and valid
>  	 *
> -- 
> 2.17.1
>