linux-kernel - Re: [PATCH v2] Documentation: media: *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191024140428.GF3966@mara.localdomain>
Date:   Thu, 24 Oct 2019 17:04:29 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Ricardo Ribalda Delgado <ribalda@...nel.org>
Cc:     Hans Verkuil <hverkuil-cisco@...all.nl>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Documentation: media: *_DEFAULT targets for subdevs

Hi Ricardo,

On Thu, Oct 24, 2019 at 03:43:36PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Sakari
> 
> Lets say the user wants to select the active pixels. He needs to set
> the crop and the compose.
> 
> 1) he gets V4L2_SEL_TGT_CROP_DEFAULT
> 
> 2) he sets V4L2_SEL_TGT_CROP
> 
> How does he knows which compose to use? What if the compose starts at
> (0,0) instead of (32,32)....?
> 
> I think it is easier if
> 
> 3) he gets V4L2_SEL_TGT_COMPOSE_DEFAULT
> 
> 4) he sets V4L2_SEL_TGT_COMPOSE
> 
> This is similar as how we do it today with a v4l2_device. What if we
> simply replicate that behaviour?

The compose rectangle is relative to the crop rectangle (if there's a crop
rectangle), and always starts at 0,0.

See:

<URL:https://hverkuil.home.xs4all.nl/spec/uapi/v4l/dev-subdev.html#selections-cropping-scaling-and-composition>

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com