linux-kernel - Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1910240810420.20010@viisi.sifive.com>
Date:   Thu, 24 Oct 2019 08:17:59 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Michal Simek <michal.simek@...inx.com>
cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        palmer@...ive.com, hch@...radead.org, longman@...hat.com,
        helgaas@...nel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jackie Liu <liuyun01@...inos.cn>,
        Wesley Terpstra <wesley@...ive.com>,
        Firoz Khan <firoz.khan@...aro.org>, sparclinux@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-riscv@...ts.infradead.org, linux-arch@...r.kernel.org,
        James Hogan <jhogan@...nel.org>,
        Vineet Gupta <vgupta@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Burton <paul.burton@...s.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-snps-arc@...ts.infradead.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Biggers <ebiggers@...gle.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-mips@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm
 header

On Thu, 24 Oct 2019, Michal Simek wrote:

> msi.h is generic for all architectures expect of x86 which has own version.
> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
> 
> Suggested-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/

[ ... ]

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += percpu.h
>  generic-y += preempt.h
>  generic-y += sections.h

Acked-by: Paul Walmsley <paul.walmsley@...ive.com> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@...ive.com> # build only, rv32/rv64

Thanks Michał,


- Paul