linux-kernel - RE: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F7F4AEDED@ORSMSX115.amr.corp.intel.com>
Date:   Thu, 24 Oct 2019 16:57:28 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Stephane Eranian" <eranian@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

> arch/ia64 has a read_persistent_clock64() function, so it ends up reading
> the system time regardless of the RTC driver or CONFIG_RTC_HCTOSYS.
>
> As ia64 sets neither ARCH_HIBERNATION_POSSIBLE nor
> ARCH_SUSPEND_POSSIBLE, so we could just remove the
> read_persistent_clock64() and efi_gettimeofday(), relying instead
> on user space (/sbin/hwclock) or CONFIG_RTC_HCTOSYS.

Seems weird. ia64 has always assumed from day 1 that it is running
on a UEFI capable platorm (well at day 1 it was called "EFI", the "U"
came later).

So read_persistent_clock64() just calls EFI directly to get the time.

Seems simpler than worrying about having the right drivers and CONFIG
bits set.

-Tony