linux-kernel - Re: [PATCH] kbuild: remove unneeded variable, single-all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQE=rewN+ei8C=9jq-79ki=foPtXwxbXTAOSRYhw6kJAA@mail.gmail.com>
Date:   Fri, 25 Oct 2019 02:20:00 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: remove unneeded variable, single-all

On Wed, Oct 16, 2019 at 2:12 PM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> When single-build is set, everything in $(MAKECMDGOALS) is a single
> target. You can use $(MAKECMDGOALS) to list out the single targets.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>

Applied to linux-kbuild.

>  Makefile | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ffd7a912fc46..710199f60c30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1764,11 +1764,9 @@ tools/%: FORCE
>
>  ifdef single-build
>
> -single-all := $(filter $(single-targets), $(MAKECMDGOALS))
> -
>  # .ko is special because modpost is needed
> -single-ko := $(sort $(filter %.ko, $(single-all)))
> -single-no-ko := $(sort $(patsubst %.ko,%.mod, $(single-all)))
> +single-ko := $(sort $(filter %.ko, $(MAKECMDGOALS)))
> +single-no-ko := $(sort $(patsubst %.ko,%.mod, $(MAKECMDGOALS)))
>
>  $(single-ko): single_modpost
>         @:
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada